-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow supplying custom workflow yaml for infer_with_model job #7902
Conversation
…erence for custom models
…ing more explicit via using a checkbox
probably read for review now, right? |
frontend/javascripts/oxalis/view/action-bar/default-workflow.ts
Outdated
Show resolved
Hide resolved
The worker side isn’t ready, I’ll do some end-to-end testing next. I think that more checkboxes may arise (e.g. we will likely drop the option to select the output layer name) |
.setScale(2, BigDecimal.RoundingMode.HALF_UP)} seconds and was${if (result.header.status != 200) " not " | ||
else " "}successful" | ||
val debugString = | ||
s"Request ${request.method} ${request.uri} took ${BigDecimal(executionTime.toMillis.toDouble / 1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slipped in here: the decimals were lost due to integer division
frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx
Outdated
Show resolved
Hide resolved
@MichaelBuessemeyer could you please take a look at Philpp’s frontend comments? |
testing went ok 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelBuessemeyer could you please take a look at Philpp’s frontend comments?
Thanks for the ping. Done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a conflict to resolve, but other than that, everything seems good 👍
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
--until
call, compare discussionIssues: