-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FATAL: role "postgres" does not exists
for docker compose deployment
#8240
Conversation
📝 WalkthroughWalkthroughThe pull request introduces multiple updates to the WEBKNOSSOS project, including new functionalities for dataset management and user interface improvements. Key changes involve the ability to ignore specific format prefixes in remote URIs, enhanced dataset tooltips, and the renaming of "resolution" to "magnification." Bug fixes address various issues in dataset handling, including performance and validation errors. Additionally, the Changes
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)CHANGELOG.unreleased.md (1)
The changelog entry accurately describes the fix and is properly categorized under the "Fixed" section with the correct PR reference. docker-compose.yml (2)
The timing configuration provides a good balance between responsiveness and reliability:
The updated health check command properly aligns with the PostgreSQL container configuration by:
Let's verify the configuration consistency: ✅ Verification successfulHealth check configuration is consistent and well-configured The verification confirms that:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that health check parameters match the PostgreSQL configuration
# Check if the database name and user in health check match the environment variables
rg -A 3 'POSTGRES_(DB|USER)' docker-compose.yml
# Check if the health check timing parameters are reasonable
rg -A 3 'healthcheck:.*postgres' docker-compose.yml
Length of output: 799 Script: #!/bin/bash
# Let's check the healthcheck configuration parameters for postgres service
rg -B 2 -A 5 'healthcheck:.*postgres|test:.*pg_isready' docker-compose.yml
Length of output: 306 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
URL of deployed dev instance (used for testing):
Steps to test:
docker compose up -d webknossos
and attach to the logs of postgresdocker compose logs -f webknossos-postgres-persistent-1
. These log should not contains the above error message.TODO
pg_isready
reports postgres as running, but does not check the user/db availability; The error is logged by postgres)Issues:
FATAL: role "postgres" does not exists
(Please delete unneeded items, merge only when none are left open)