Fixed caching behavior in JwtTokenResolverImpl, no cache for errors (#90

) * Fixed caching behavior in JwtTokenResolverImpl, no cache for errors * Fixed tests (updated testcontainers)
scalecube · Feb 24, 2021 · fa7a4a9 · fa7a4a9
1 parent 12fe5a8
commit fa7a4a9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/pom.xml b/pom.xml
@@ -47,7 +47,9 @@
     <hamcrest.version>1.3</hamcrest.version>
     <junit-jupiter.version>5.4.2</junit-jupiter.version>
     <vault-java-driver.version>5.0.0</vault-java-driver.version>
-    <testcontainers.version>1.14.0</testcontainers.version>
+    <testcontainers.version>1.15.1</testcontainers.version>
+    <!-- TODO: remove explicit version of `jna` once testcontainers fixes dependencies conflict -->
+    <jna.version>5.5.0</jna.version>
   </properties>
 
   <dependencyManagement>
@@ -90,6 +92,13 @@
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+      <!-- TestContainers -->
+      <dependency>
+        <groupId>net.java.dev.jna</groupId>
+        <artifactId>jna</artifactId>
+        <version>${jna.version}</version>
+        <scope>test</scope>
+      </dependency>
     </dependencies>
   </dependencyManagement>
 

diff --git a/tokens/src/main/java/io/scalecube/security/tokens/jwt/JwtTokenResolverImpl.java b/tokens/src/main/java/io/scalecube/security/tokens/jwt/JwtTokenResolverImpl.java
@@ -102,7 +102,10 @@ private Mono<Key> findKey(String kid, AtomicReference<Mono<Key>> computedValueHo
         (kid1) -> {
           Mono<Key> result =
               computedValueHolder.updateAndGet(
-                  mono -> Mono.defer(() -> keyProvider.findKey(kid)).cache());
+                  mono ->
+                      Mono.defer(() -> keyProvider.findKey(kid1))
+                          .cache()
+                          .doOnError(ex -> keyResolutions.remove(kid1)));
           scheduleCleanup(kid, computedValueHolder);
           return result;
         });