Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): add fetch-keys to ssh commands #4622

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

Mia-Cross
Copy link
Contributor

Closes #2356

@Mia-Cross Mia-Cross self-assigned this Mar 31, 2025
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Mar 31, 2025
@Mia-Cross Mia-Cross force-pushed the instance_enroll_new_ssh_key branch from 7d94846 to 8fdd9c6 Compare April 1, 2025 08:53
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 33.75000% with 53 lines in your changes missing coverage. Please review.

Project coverage is 55.10%. Comparing base (5bf53e0) to head (38d5db9).
Report is 571 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/custom_ssh_key.go 32.91% 52 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (38d5db9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (38d5db9)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4622       +/-   ##
===========================================
- Coverage   75.45%   55.10%   -20.35%     
===========================================
  Files         202      308      +106     
  Lines       44323    70040    +25717     
===========================================
+ Hits        33444    38597     +5153     
- Misses       9653    30045    +20392     
- Partials     1226     1398      +172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross force-pushed the instance_enroll_new_ssh_key branch from 31a28ac to 23f7c6d Compare April 1, 2025 09:03
@Mia-Cross Mia-Cross marked this pull request as ready for review April 1, 2025 09:17
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners April 1, 2025 09:17
@Mia-Cross Mia-Cross force-pushed the instance_enroll_new_ssh_key branch from 6fcb7b1 to 5805be5 Compare April 1, 2025 11:56
@Mia-Cross Mia-Cross force-pushed the instance_enroll_new_ssh_key branch from 79afb23 to 2721b9f Compare April 1, 2025 12:06
@remyleone remyleone added this pull request to the merge queue Apr 2, 2025
Merged via the queue into scaleway:master with commit 157a515 Apr 2, 2025
14 checks passed
@Mia-Cross Mia-Cross deleted the instance_enroll_new_ssh_key branch April 2, 2025 12:53
Laure-di pushed a commit to remyleone/scaleway-cli that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hassle updating all scaleway instances after adding a new ssh key
4 participants