Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Banner): add image in a img tag when is a string #4504

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

Refactor image prop in <Banner /> component. If the prop is a string, it will be displayed inside img tag so you can set a url to simply set the image.

@matthprost matthprost added the enhancement New feature or request label Nov 26, 2024
@matthprost matthprost requested review from BABAK0T0 and a team November 26, 2024 14:43
@matthprost matthprost self-assigned this Nov 26, 2024
Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: dd0d25b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1537a93). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/Banner/index.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4504   +/-   ##
=======================================
  Coverage        ?   86.78%           
=======================================
  Files           ?      326           
  Lines           ?    11935           
  Branches        ?     3313           
=======================================
  Hits            ?    10358           
  Misses          ?     1577           
  Partials        ?        0           
Files with missing lines Coverage Δ
packages/ui/src/components/Banner/index.tsx 94.28% <33.33%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1537a93...dd0d25b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants