-
Couldn't load subscription status.
- Fork 252
CLDSRV-769: Add raftSessionId to BucketInfo #5979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello dvasilas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
❌ 1 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
lib/metadata/metadataUtils.js
Outdated
| getOptions.getDeleteMarker = true; | ||
| } | ||
| return metadata.getBucketAndObjectMD(bucketName, objectKey, getOptions, log, (err, getResult) => { | ||
| return metadata.getBucketAndObjectMD(bucketName, objectKey, getOptions, log, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to update standardMetadataValidateBucket also
lib/metadata/metadataUtils.js
Outdated
| const bucket = getResult.bucket ? | ||
| BucketInfo.deSerialize(getResult.bucket) : undefined; | ||
| if (raftSessionId !== undefined) { | ||
| bucket.setRaftSessionId(raftSessionId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do the set here instead of inside arsenal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's to avoid an extra JSON.parse followed by JSON.stringify (to store the RAFT session ID in the returned JSON string).
2c6770b to
f6b2b21
Compare
|
@leif-scality @jonathan-gramain I updated the Arsenal PR: scality/Arsenal#2560 We no longer add I only updated tests for now. @leif-scality I leave it to you in your PR to update the callbacks to get |
package.json
Outdated
| "@azure/storage-blob": "^12.28.0", | ||
| "@hapi/joi": "^17.1.1", | ||
| "arsenal": "git+https://github.com/scality/Arsenal#8.2.33", | ||
| "arsenal": "git+https://github.com/scality/Arsenal#be4537c05698fc0f57b5e63ea756806e3b3cb0e5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: don't forget to use release.
f6b2b21 to
2412bfa
Compare
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/improvement/CLDSRV-769 && \
git merge origin/development/9.1Resolve merge conflicts and commit git push origin HEAD:improvement/CLDSRV-769 |
2412bfa to
ae9f7cd
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-769. Goodbye dvasilas. The following options are set: approve |
raftSessionIdneeds to be logged for the bucket logging feature.