Skip to content

Started migration for buckerVersionStats #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: development/1.16
Choose a base branch
from
Open

Started migration for buckerVersionStats #351

wants to merge 2 commits into from

Conversation

SylvainSenechal
Copy link
Contributor

@SylvainSenechal SylvainSenechal commented Sep 23, 2025 •
edited
Loading

Issue : S3UTILS-200

@bert-e
Copy link
Contributor

bert-e commented Sep 23, 2025

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 23, 2025

Incorrect fix version

The Fix Version/s in issue S3UTILS-200 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.16.2

Please check the Fix Version/s of S3UTILS-200, or the target
branch of this pull request.

SylvainSenechal
SylvainSenechal commented Sep 23, 2025
View reviewed changes
bucketVersionsStats.js
total: {
count: BigInt(stats.current.count + stats.noncurrent.count),
size: BigInt(stats.current.size + stats.noncurrent.size),
count: String(stats.current.count + stats.noncurrent.count),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was a weird error with the logger when using bigInt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure if String() function shoud be used (as you did), or if the toString() method should be preferred. I did not find any mention of BigInt support with the String() function, though running in a node.js shell it seems to work just as well... 🤷‍♂️

SylvainSenechal
SylvainSenechal commented Sep 23, 2025
View reviewed changes
cleanupNoncurrentVersions.js
log.error('batch delete error', { error: err });
});

command.middlewareStack.add(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get a badDigest error without this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as #348 (comment)

@SylvainSenechal SylvainSenechal marked this pull request as ready for review September 23, 2025 16:37
francoisferrand
francoisferrand approved these changes Sep 29, 2025
View reviewed changes
bucketVersionsStats.js
total: {
count: BigInt(stats.current.count + stats.noncurrent.count),
size: BigInt(stats.current.size + stats.noncurrent.size),
count: String(stats.current.count + stats.noncurrent.count),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure if String() function shoud be used (as you did), or if the toString() method should be preferred. I did not find any mention of BigInt support with the String() function, though running in a node.js shell it seems to work just as well... 🤷‍♂️

cleanupNoncurrentVersions.js
log.error('batch delete error', { error: err });
});

command.middlewareStack.add(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as #348 (comment)

@bert-e
Copy link
Contributor

bert-e commented Sep 29, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisferrand francoisferrand francoisferrand approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SylvainSenechal @bert-e @francoisferrand