-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: CircleCI config removed #246
Conversation
a905956
to
23792c3
Compare
3137524
to
951ec61
Compare
.github/workflows/changelog.yml
Outdated
- name: Changelog Tool | ||
uses: rcmachado/changelog-action@v1 | ||
with: | ||
args: init --output CHANGELOG.md --compare-url https://keepachangelog.com/en/1.0.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamaia is this the correct way of using the Changelog Tool or should I keep this in the lint.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pradhvan I believe the command can be the same we are already using: https://github.com/scanapi/scanapi/blob/master/.circleci/config.yml#L17
From what I understood, init would create a new file, but here we only want to check the lint, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamaia You're correct - init
will initialize a new file. But as there is no lint
command yet, the diff
command should be used instead (there is an issue open to implement it: rcmachado/changelog#71).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the diff[0] but it's not working. I you can take a look @rcmachado it would be a great help.
[0]https://github.com/scanapi/scanapi/pull/246/checks?check_run_id=932150102
@rcmachado would you mind to giving us some help reviewing this PR? |
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
### Removed | |||
- APIKeyMissingError [#218](https://github.com/scanapi/scanapi/pull/218) | |||
- Move Changelog Lint from CircleCI to GitHub Actions [#139](https://github.com/scanapi/scanapi/issues/139) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be in the Changed
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinigfer yes will move it. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we need to get te diff
argument working in the action
a44b724
to
65e9331
Compare
.github/workflows/changelog.yml
Outdated
- name: Changelog Tool | ||
uses: rcmachado/changelog-action@v1 | ||
with: | ||
args: diff -u <(changelog fmt -f CHANGELOG.md) CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pradhvan the problem here is because args
is what is being passed as the argument to the changelog
command. This diff
you want is system's. The way it is implemented here, GitHub Actions is going to call:
$ changelog diff -u <(changelog fmt -f CHANGELOG.md) CHANGELOG.md
... resulting in an error given that the tool has no argument called diff
.
There are a few ways to solve this:
- Implement the
diff
command on @rcmachado 's tool (or as he points out in Add --check option to fmt rcmachado/changelog#71:fmt --check
) - Do not use his GitHub Action and simply download and execute the command yourself
- Keep using his GitHub Action but try to play with shell arguments to execute
fmt
, get the results from it, and then call system's diff
IMO:
- 1 is the best option if you know (or want to play with) Golang.
- 3 might work well if you know how to use
xargs
(I don't 😅) - 2 could be achieved by some sort of the following commands:
- name: Changelog Tool
- run: |
go get github.com/rcmachado/changelog
diff -u <(./bin/changelog fmt -f CHANGELOG.md) CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barbosa fun thing is I actually picked up Go and will go for 1 😄
3a3c742
to
35724ec
Compare
Fix Publish to Test PyPI Action
Co-authored-by: Flavio Sales Truzzi <[email protected]>
dad9d99
to
7beba90
Compare
I might not be able to give time on this. So closing the PR. |
Removed Circle CI config for changelog management
closes #139