[#173] Migrate cql-antlr from its own repo to a submodule #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From scassandra/cql-antlr#3 we discussed moving cql-antlr in as a submodule to make it easier to coordinate changes in scassandra that require changes to cql-antlr.
This works good, but currently there is something I need to fix in the gradle-build for cql-antlr. It builds properly, but the travis build fails because successive runs don't properly skip the antlr4 task that was previously run because i currently have it set up to generate license headers in the generated files. This is so the license checker doesn't fail. I could disable generating license headers for generated code, but then the license checker fails because
excludes
option in the checker doesn't work for generated code (since it evaluates which code to exclude first). Anyways..I plan on finding a strategy for that tomorrow. This is only a problem for the travis build because it builds with java 8, then runs tests with java 6.This does not include the changes for scassandra/cql-antlr#3, I will incorporate those in #171 after this pr is merged.
I also was able to import the commit history from cql-antlr repo into this one. I didn't even know that was possible, neat!