Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/sinks from NWM: inaccurate intersecting elements #113

Open
feiye-vims opened this issue Jan 9, 2024 · 1 comment
Open

sources/sinks from NWM: inaccurate intersecting elements #113

feiye-vims opened this issue Jan 9, 2024 · 1 comment

Comments

@feiye-vims
Copy link
Member

feiye-vims commented Jan 9, 2024

The boundary elements where sources are injected are found by intersecting the SCHISM land boundary and NWM segments.

Ideally, an intersecting element (i.e., a source element or the parent element of the intersection point) should be identified when the intersection point is found.

However, it seems the source/sink element is found by first finding the intersection point, then searching the nearest element center. This is not equivalent to directly locating the intersecting element and could lead to slight misplacement of sources/sinks.

@feiye-vims
Copy link
Member Author

feiye-vims commented Apr 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant