-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Office of Water Prediction NextGen Hydrofabric for Source/Sink Construction of SCHISM mesh #121
base: main
Are you sure you want to change the base?
Conversation
Adding NextGen ReadMe text file to indicate that T-Route database is still under development and no applicable test case can be developed here yet.
Include NextGen Source Sink creation feature capability.
Include NextGen Source Sink Creation Option.
NextGen module for constructing a source.nc file from scratch using a SCHISM hgrid.gr3 file and linking source/sink elements from the NextGen hydrofabric geopackage file. This module will produce a source.nc file for the SCHISM BMI only currently since there is no NextGen T-Route repository for retrospective streamflow data.
Example Python script to construct a source.nc file from scratch using the SCHISM hgrid.gr3 file and a NextGen hydrofabric geopackage file. This will only produce a source.nc file compatible for the SCHISM Basic Model Interace (BMI), which assumes that all elements are eligible for additional source terms from precipitation fields coming from the NextGen Forcings Engine
Thx @jduckerOWP ! |
I don't think the new code interferes with any existing functions. In fact, it is the original element paring function that has minor problems. Thanks @jduckerOWP |
@feiye-vims is there an issue created on the PySCHISM page to describe the problem with the original element pairing problem? I'll be happy to take a look at it and see if our team can help fix the issues in the future. The idea here for the NextGen module was to at least mimic the process for creating the source.nc file with the original NWM vector-based routing network. However, we want to certainly fix the code if issues are introduced as well with linking the NextGen hydrofabric flow path network with the hgrid.gr3 file elements. Thanks again @josephzhang8 and @feiye-vims for both looking at this pull request quickly! |
@jduckerOWP Some other users and I identified the issue, and I briefly summarized it in issue #113. Everybody in our group is tied up with other more urgent tasks, so we haven't fixed it. |
The Office of Water Prediction is currently developing the Next Generation Water Resources Modeling Framework (NextGen) project using SCHISM as a coastal model. We are constructing a common hydrofabric to apply a new routing network model called T-Route, which is constrained to the NextGen hydrofabric itself. The NextGen hydrofabric encapsulates the flow path geometry information within a geopackage file. This pull request aims to accomplish the following:
I'll be happy to answer any questions or work with developers to merge this PySCHISM branch into the main branch of the repository.