Repository navigation
docs(plans): land epic #3150 batch 1 — generic chat attachment intake, ownership and on-demand reading design - #3523
Merged
Merged
Conversation
…demand reading (#3301) Deliver the #3151 design spike for epic #3150 on its integration branch: - docs/plans/chat-attachments.md: source inventory from picker to provider, a capability matrix from installed source and a keyless pdfjs-dist probe, byte-first routing precedence, the outcome vocabulary, the neutral composer-upload route, reference/draft/outgoing/message ownership, pool accounting and race-safe cleanup, the bounded read_attachment tool, 320px/desktop mocks with state/copy, compatibility, proposed contract changes and per-child proof briefs. Recommendations are listed apart from rulings. - docs/decisions/chat-attachments.md: the maintainer rulings of 2026-10-29 and 2026-11-02 with links, and rejected alternatives. - D52: record the approved generic-original lifetime and limit amendment. - scripts/sync-project.ts: put epic #3150 on the Answer quality track. No runtime behaviour changes. Refs #3151 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/plans/README.md
# Conflicts: # scripts/sync-project.ts
schlessera
marked this pull request as ready for review
November 3, 2026 23:30
7 of 8 tasks
8 tasks done
schlessera
marked this pull request as draft
November 4, 2026 03:40
schlessera
marked this pull request as ready for review
November 4, 2026 03:40
Owner
Author
|
Landed as merge commit |
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3151
Refs #3150
What changed
This PR lands batch 1 of epic #3150 (
epic/3150-attachments) on main:4cd19855219c8bcdfafb8a1104161a90093c5796docs/plans/chat-attachments.mddesigns generic chat attachment intake, ownership and on-demand reading.This PR adds nothing beyond it, apart from merge commit
b741ae0ad, which bringsorigin/main(90aebd916) into the epic. One conflict, indocs/plans/README.md: main had retired shipped plans and added an Open work column. The resolution keeps main's table and adds thechat-attachments.mdrow, owned by #3150.Why this shape
This follows the maintainer ruling of 2026-11-02 for the 0.45.0 epic run, under which each batch lands on main as one PR with a merge commit, so every sub-PR's squash stays bisectable on main. Under the maintainer's later ruling, it lands only after the full ready-candidate proof, under the integration lease.
Proof
On
b741ae0ad, with a privateTMPDIR:32c005e7fbringsorigin/main(bb91defdc) into the epic without conflicts. On it: install, typecheck, build and lint clean, andcheck:pr1181 pass, 0 fail. The receipt below is from that run.9805f52fd: merge commitb54027b5c. One conflict, inscripts/sync-project.ts: both sides added an epic to the "Answer quality" track, this one Epic: attach any file and route its contents through available capabilities #3150 and main Epic: external compute runs through interchangeable sandbox providers #3103. The resolution keeps both. On the merge: install, typecheck, build and lint clean, andcheck:pr1196 pass, 0 fail. The receipt below is from that run.check:pr receipt
{"version":1,"kind":"brain-check-pr-receipt","head":"7e1a23ef87c55e30215080ea57bce442a077cd2e","base":"origin/main","mode":"focused","startedAt":"2026-11-04T03:38:31.732Z","finishedAt":"2026-11-04T03:40:13.397Z","checks":[{"name":"all lint and leakage gates","categories":["changeset"],"outcome":"passed","elapsedMs":10890.156235},{"name":"environment documentation","categories":["changeset"],"outcome":"passed","elapsedMs":129.10731400000077},{"name":"pending changeset package names","categories":["changeset"],"outcome":"passed","elapsedMs":111.09675699999934},{"name":"contribution changeset","categories":["changeset"],"outcome":"passed","elapsedMs":20.813367999999173},{"name":"affected fast invariants","categories":["verify","unit"],"outcome":"passed","elapsedMs":90492.828612}]}Checklist
docs/reflect the change.Anything left open
Open sub-PR #3342 (generic chat file admission) is not part of this batch.
🤖 Generated with Claude Code