Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quotes trimmed even if not at START and END #33

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix quotes trimmed even if not at START and END #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions wrapper/wrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,11 @@ func convertValue(fieldType reflect.Type, value string) (reflect.Value, error) {
return setValue.Elem(), nil

case reflect.String:
return reflect.ValueOf(
strings.Trim(value, `"`),
).Convert(fieldType), nil
trimed := value
if len(trimed) > 2 && trimed[0] == '"' && trimed[len(trimed)-1] == '"' {
trimed = trimed[1 : len(trimed)-1] // remove quotes only if they are at the beginning AND the end
}
return reflect.ValueOf(trimed).Convert(fieldType), nil

case reflect.Bool:
setValue, err := strconv.ParseBool(value)
Expand Down
Loading