Code

Refactor the codebase#86

Code

Draft

ewen-lbh wants to merge 57 commits intomasterschoolsyst/webapp:masterfrom refactor-2020-05schoolsyst/webapp:refactor-2020-05Copy head branch name to clipboard

+3,530-1,004

Commits

Commits on May 6, 2020

• 📝 ORGANIZING_COMPONENTS: Adjust component tree

  ewen-lbh

  committed
  e5b6fdf

  Copy full SHA for e5b6fdf

• ♻️ Add new component files to match the goal component tree

  ewen-lbh

  committed
  0ba8c3f

  Copy full SHA for 0ba8c3f

Commits on May 17, 2020

• 🚚 Move old components to ~/components/legacy/

  ewen-lbh

  committed
  b127f58

  Copy full SHA for b127f58

• 🚧 Create <BaseButton>, <BaseCard> and <ButtonPrimary>

  ewen-lbh

  committed
  ae1abd3

  Copy full SHA for ae1abd3

Commits on May 18, 2020

• 🚧 <ButtonPrimary> Handle [dangerous] *and* [disabled]

  ewen-lbh

  committed
  afac96e

  Copy full SHA for afac96e

• 🚚 Move legacy component tests

  ewen-lbh

  committed
  d37399c

  Copy full SHA for d37399c

• 💄 <ButtonPrimary> Add display: inline-block

  ewen-lbh

  committed
  6b7fc2f

  Copy full SHA for 6b7fc2f

• 📝 CONTRIBUTING: Use HTML instead of pug

  Show description for 05f1f81
  ewen-lbh

  committed
  05f1f81

  Copy full SHA for 05f1f81

• 🚧 <BaseButton> Centralized [disabled], handle [href]

  ewen-lbh

  committed
  9cd20ab

  Copy full SHA for 9cd20ab

• 💄 material-icons: Convert font-size to ems

  ewen-lbh

  committed
  5d46745

  Copy full SHA for 5d46745

• 🚧 <ButtonSecondary> :active state

  ewen-lbh

  committed
  99ca759

  Copy full SHA for 99ca759

• ♻️ <Button*> extend <BaseButton> instead of redeclaring props

  ewen-lbh

  committed
  4d060cd

  Copy full SHA for 4d060cd

• ♻️ Put potentially re-usable functions in utils/

  ewen-lbh

  committed
  b85994c

  Copy full SHA for b85994c

• 🐛 validators: Change from ts to js

  Show description for 94adf16
  ewen-lbh

  committed
  94adf16

  Copy full SHA for 94adf16

• 🔧 Add typescript

  ewen-lbh

  committed
  bf0d554

  Copy full SHA for bf0d554

Commits on May 19, 2020

• ♻️ <ButtonIcon> Switch to TS

  ewen-lbh

  committed
  6eb4c3d

  Copy full SHA for 6eb4c3d

• 💄 <ButtonIcon> Handle [small]

  ewen-lbh

  committed
  051af02

  Copy full SHA for 051af02

• ✨ Create <SubjectBadge>

  ewen-lbh

  committed
  e00b3da

  Copy full SHA for e00b3da

• 🏷️ <BaseButton> Switch to typescript

  ewen-lbh

  committed
  e93d746

  Copy full SHA for e93d746

• ✨ <BaseButton> Handle [href]

  ewen-lbh

  committed
  458accb

  Copy full SHA for 458accb

• 💄 ^utils: Fix lightColor and darkColor, add blackOrWhite

  ewen-lbh

  committed
  f5b9cf7

  Copy full SHA for f5b9cf7

• 🏷️ Add vue-shim.d.ts

  ewen-lbh

  committed
  2202e93

  Copy full SHA for 2202e93

• 🚧 ♻️ <TimeTable> Refactor from <Schedule>

  Show description for 4f88421
  ewen-lbh

  committed
  4f88421

  Copy full SHA for 4f88421

• 🚚 Rename <SubjectBadge> to <BadgeSubject>

  ewen-lbh

  committed
  9c47380

  Copy full SHA for 9c47380

Commits on May 21, 2020

• 🔌 Create <TextLink>, remove link styling from global style rules

  ewen-lbh

  committed
  560c78b

  Copy full SHA for 560c78b

• 🔌 Add isIn validator

  ewen-lbh

  committed
  0e19a64

  Copy full SHA for 0e19a64

• 🔌 <TextLink> Handle internal & external links properly

  ewen-lbh

  committed
  9753bd0

  Copy full SHA for 9753bd0

• 🚧 Start creating <BaseInput>

  ewen-lbh

  committed
  96edc76

  Copy full SHA for 96edc76

Commits on May 22, 2020

• 📝 CONTRIBUTING: Add section about outer margins on components

  ewen-lbh

  committed
  e7ce25c

  Copy full SHA for e7ce25c

• Merge branch 'refactor-2020-05' of https://github.com/schoolsyst/frontend into refactor-2020-05

  ewen-lbh

  committed
  aedf9e4

  Copy full SHA for aedf9e4

• 🐛 <TextLink> Apply noopener, noreferrer to isExternal, not [new-tab]

  ewen-lbh

  committed
  826c22b

  Copy full SHA for 826c22b

• 🔧 tsconfig: Temporarily disable libCheck

  Show description for a1df55b
  ewen-lbh

  committed
  a1df55b

  Copy full SHA for a1df55b

• 🏷️ <TimeTable> Fix type errors

  Show description for 914089e
  ewen-lbh

  committed
  914089e

  Copy full SHA for 914089e

• 💡 <TimeTable> Comment methods.handleEventClick

  ewen-lbh

  committed
  e316274

  Copy full SHA for e316274

• 🏷️ <TimeTable> Fix handleHover's typing issue

  Show description for b6682c8
  ewen-lbh

  committed
  b6682c8

  Copy full SHA for b6682c8

• ⚗ Create /refactor-test

  ewen-lbh

  committed
  c49c598

  Copy full SHA for c49c598

• 📝 CONTRIBUTING: Simpler structure for store action functions

  ewen-lbh

  committed
  914cb20

  Copy full SHA for 914cb20

• 🚨 eslint: Warn on camelcase, don't fail with an error

  Show description for 887ca10
  ewen-lbh

  committed
  887ca10

  Copy full SHA for 887ca10

• 🏷️ Define types for homework, notes and quizzes

  ewen-lbh

  committed
  8338c66

  Copy full SHA for 8338c66

• 💄 <BadgeSubject> Make the dot smaller

  ewen-lbh

  committed
  d83f5a1

  Copy full SHA for d83f5a1

• 🚧 🔌 <BaseButton> Allow any URL

  ewen-lbh

  committed
  744a541

  Copy full SHA for 744a541

• 🐛 <BaseCard> Make it an importable component, format code

  ewen-lbh

  committed
  898cbd0

  Copy full SHA for 898cbd0

• 🐛 <Button*> Forward click events

  ewen-lbh

  committed
  41ca65b

  Copy full SHA for 41ca65b

• 💄 <ButtonIcon> Remove side padding

  ewen-lbh

  committed
  50aa87f

  Copy full SHA for 50aa87f

• 🐛 <TextLink> Remove URL validation

  Show description for ac511a2
  ewen-lbh

  committed
  ac511a2

  Copy full SHA for ac511a2

• 🚧 Start making <CardHomework>

  ewen-lbh

  committed
  532df24

  Copy full SHA for 532df24

• 🔧 tsconfig: exclude legacy components

  ewen-lbh

  committed
  32abcf3

  Copy full SHA for 32abcf3

• 🔌 validators: Add isUUID

  ewen-lbh

  committed
  70a68e3

  Copy full SHA for 70a68e3

Commits on May 24, 2020

• 🔀 origin/refactor-2020-05 into refactor-2020-05

  ewen-lbh

  committed
  bfc6247

  Copy full SHA for bfc6247

• ♻️ Add <CardAdd>

  ewen-lbh

  committed
  78b0ce7

  Copy full SHA for 78b0ce7

• ♻️ <BaseCard> Separate border-color from border

  ewen-lbh

  committed
  0b41c57

  Copy full SHA for 0b41c57

• ♻️ <CardAdd> Detach from <BaseCard>

  Show description for a069240
  ewen-lbh

  committed
  a069240

  Copy full SHA for a069240

Commits on May 25, 2020

• 🚧 Create heading components

  ewen-lbh

  committed
  0a255f3

  Copy full SHA for 0a255f3

Commits on May 27, 2020

• 💄 <BaseInput> Add styling, allow more [element]s

  ewen-lbh

  committed
  8cc2f1e

  Copy full SHA for 8cc2f1e

• 🔌 Create <InputText>

  ewen-lbh

  committed
  8ff5cdf

  Copy full SHA for 8ff5cdf

• 💄 <ButtonPrimary> Make [small] version less tall

  ewen-lbh

  committed
  7a5a1a2

  Copy full SHA for 7a5a1a2

• 🚧 🏷️ Started typing & reworking the store

  Show description for a3a3992
  ewen-lbh

  committed
  a3a3992

  Copy full SHA for a3a3992