Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventEmitter bug fix #336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

EventEmitter bug fix #336

wants to merge 2 commits into from

Commits on Oct 4, 2018

  1. EventEmitter bug fix 

    this.tmpArray was not cleaned after every event emission. This caused listeners to leak to the events they don't belong to and crash the app. 

By the way, do we really need to store tmpArray globally (this.tmpArray)? Maybe just create an empty local tmpArray every time?
    George Turkin committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    b754868 View commit details
    Browse the repository at this point in the history

  2. fix 

    the previous attempt didn't help, removed this.tmpArray. Now it works
    George Turkin committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    857b1ee View commit details
    Browse the repository at this point in the history