Stable #366
Open
Stable #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properties in for/while loop, changed functions that use .indexOf with high usage to a forloop and finally improved resetting of a tupleDictionary, tests succeeded except the functions that returns a float32 array
feat: improve perf
feat: create collision group for player & everything except player
|
@schteppe Hello man! You dont work on this repo any more, right? Please, approve people PRs, thats very usefull! |
spasma
reviewed
Feb 13, 2023
| @@ -2,6 +2,9 @@ module.exports = Shape; | |||
|
|
|||
| var vec2 = require('../math/vec2'); | |||
|
|
|||
| let PLAYER = Math.pow(2,0); | |||
| let EVERYTHING_EXCEPT_PLAYER = Math.pow(2,1); | |||
There was a problem hiding this comment.
These must be vars to make grunt work correctly
amytimed
added a commit
to Carroted/p2-es
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.