Make code work on modern Python systems #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyXML is an old library that's hard to install in modern Python distributions. This commit modifies the XML parsing to instead leverage the standard library xml.etree module [1]. The module has been around since Python 2.5 which means that the updated code should run on the vast majority of modern systems. [1] https://docs.python.org/2/library/xml.etree.elementtree.html
The changes required for making the tool work in both Python 2 and Python 3 are fairly minimal and fully backwards compatible: - Use `input` instead of `raw_input`. - Use `int` instead of `string.atoi`. - Convert print statements to function calls.
|
Closing in favor of #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the code to make it work on all modern Python systems such as Python 2.7 or Python 3.5. This required two main changes:
Note that the updated code no longer supports Python 2.5 or Python 2.6 since the xml.etree library did not support XPath queries with attribute lookups (such as
country[@code]) in those versions.