Feat: add person group elem in ref elem#757
Merged
robertatakenaka merged 7 commits intoscieloorg:masterfrom Nov 21, 2024
Rossi-Luciano:add_person_group_elem_in_ref_elem
Merged
Feat: add person group elem in ref elem#757robertatakenaka merged 7 commits intoscieloorg:masterfrom Rossi-Luciano:add_person_group_elem_in_ref_elem
robertatakenaka merged 7 commits intoscieloorg:masterfrom
Rossi-Luciano:add_person_group_elem_in_ref_elem
Conversation
| "fpage": "192", | ||
| "lpage": "199", | ||
| "ext-link": [ | ||
| { |
robertatakenaka
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Complementa a função que cria o elemento
ref, no formato xml, para considerar a inserção do elementoperson-group.Onde a revisão poderia começar?
Por commit.
Como este poderia ser testado manualmente?
Sugiro avaliar os testes:
python3 -m unittest -v tests/sps/formats/sps_xml/test_ref.pyAlgum cenário de contexto que queira dar?
NA.
Screenshots
NA.
Quais são tickets relevantes?
NA.
Referências
TK #754