Skip to content

Use local system's built-in certificates when connecting to dev_s3 amazon bucket. #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eddierubeiz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use local system's built-in certificates when connecting to dev_s3 amazon bucket. #3237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/scihist_digicoll/env.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,20 @@ def self.appropriate_shrine_storage(bucket_key:, public: false, mode: lookup!(:s
prefix: "#{lookup(:s3_dev_prefix)}/#{shared_bucket_path_prefix}",
access_key_id: lookup(:aws_access_key_id),
secret_access_key: lookup(:aws_secret_access_key),
region: lookup(:aws_region)
region: lookup(:aws_region),
# Force a concrete, known-good CA bundle.
# Fixes a bug with Ruby 3.4 + OpenSSL 3.5 on macOS in
# which:
# SSLContext#cert_store starts out nil;
# somewhere in the AWS SDK / Net::HTTP stack,
# a cert store was being constructed implicitly,
# which triggered CRL expectations,
# leading to an "unable to get certificate CRL" error
# even though the certificate chain was valid.
#
# See also https://github.com/sciencehistory/scihist_digicoll/issues/3236
#
ssl_ca_bundle: OpenSSL::X509::DEFAULT_CERT_FILE
}.merge(s3_storage_options))
elsif mode == "production"
if host.present?
Expand Down