Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GitHub artifact attestations to package distribution #933

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert self-assigned this May 22, 2024
@github-actions github-actions bot added the needs changelog Might need a changelog entry label May 22, 2024
@matthewfeickert
Copy link
Member Author

@henryiii I saw that you reran the failing Pyodide wheel tests, but they're still failing, though have to be unrelated to this PR.

@HDembinski
Copy link
Member

You requested review from me, but Henry normally handles boost-histogram. I can work on this if Henry is busy.

@matthewfeickert
Copy link
Member Author

Thanks @HDembinski. If @henryiii normally covers this then I'll let him get to it whenever he has time — no rush here. Thanks though!

@henryiii
Copy link
Member

henryiii commented May 23, 2024

Yes, I've just been hoping the pyodide test would resolve, but it looks like something has changed and I'll need to debug. Doing so in #934.

For my understanding, this only shows up in GitHub's page for now (and in the future PyPI might accept them too)?

@henryiii henryiii force-pushed the ci/add-artifact-attestations branch from 90a50fa to 859da6c Compare May 23, 2024 16:01
@henryiii henryiii merged commit 075b53f into scikit-hep:develop May 23, 2024
32 checks passed
@henryiii
Copy link
Member

Thanks!

@matthewfeickert matthewfeickert deleted the ci/add-artifact-attestations branch May 23, 2024 16:53
@matthewfeickert
Copy link
Member Author

Once this runs during a release the attestations will be uploaded to https://github.com/scikit-hep/boost-histogram/attestations and can be verified from a wheel or sdist artifact using the gh attestation verify CLI API. c.f. scikit-hep/pyhf#2473 for examples of that.

@henryiii henryiii removed the needs changelog Might need a changelog entry label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants