Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try running tests with numpy 2 #944

Closed
wants to merge 1 commit into from

Conversation

lgray
Copy link

@lgray lgray commented Jun 17, 2024

I want to see if tests fail with the recently released numpy 2.

Related to #943

@github-actions github-actions bot added the needs changelog Might need a changelog entry label Jun 17, 2024
@lgray
Copy link
Author

lgray commented Jun 17, 2024

@henryiii can you please let these tests run so we can see what fails in numpy2?

@henryiii
Copy link
Member

numpy>=2.0.0b1 is already present in the tests, so pretty sure this does work.

@lgray
Copy link
Author

lgray commented Jun 17, 2024

I do not understand how the tests are passing:
https://github.com/scikit-hep/boost-histogram/blob/develop/tests/test_axis.py#L696-L700

Requires everything to be as expected, but:

>>> bh.axis.Integer(1, 3).edges
array([3., 3., 3.])

Something is rather fishy.

@lgray
Copy link
Author

lgray commented Jun 17, 2024

Likewise:

>>> a = bh.axis.Integer(-1, 3)
>>> a
Integer(3, 3)
>>> a == (-1,0,1,2)
False

@lgray lgray closed this Jun 17, 2024
@henryiii henryiii removed the needs changelog Might need a changelog entry label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants