Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: axis metadata was broken when rebinning #978

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

henryiii
Copy link
Member

The metadata was getting an extra {"metadata": metadata} wrapped around it (and None was turning into {}). Seen in #977 (comment).

@github-actions github-actions bot added the needs changelog Might need a changelog entry label Jan 31, 2025
@henryiii henryiii force-pushed the henryiii/fix/axismetadata branch from a77988a to 806598b Compare January 31, 2025 18:20
@henryiii
Copy link
Member Author

henryiii commented Jan 31, 2025

As a followup, I think I'd like to rename .metadata on the C++ object, since it is not the same as .metadata on the Python one, and there's a high chance of confusion. It's actually the same as __dict__, which is likely a bad name, but maybe .raw_metadata or something like that would be less likely to be confused. Really anything that's not identical to .metadata. ;)

@henryiii
Copy link
Member Author

Though it's called .metadata in C++. I wonder if we could just deprecate .metadata and metadata= (on the Python object) in favor of the newer .__dict__/__dict__=?

@henryiii henryiii merged commit a6876bb into develop Jan 31, 2025
17 checks passed
@henryiii henryiii deleted the henryiii/fix/axismetadata branch January 31, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Might need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant