feat: automatically detect input format for template construction and collection CLI #537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in cabinetry/cabinetry-tutorials#20 and mentioned in #291: the
cabinetry templates
CLI so far has not supported histogram inputs. By checking for"Tree"
properties of samples, which are mandatory for ntuple inputs, we can determine it the input most likely has ntuple format. This could theoretically fail if configs are written for histograms but still set these tree properties (which do nothing in that case), so a--input_type
override can be used to correct the automatic detection if needed.The logic for the input format detection may need to be updated in case of config format changes, e.g. for features discussed in #291, #435, or #528.
resolves cabinetry/cabinetry-tutorials#20