fix: do not modify fix_pars input to fit.scan #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2148 2150 +2
Branches 299 300 +1
=========================================
+ Hits 2148 2150 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test failures are currently due to scikit-hep/pyhf#2554. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom
fix_parsarguments provided tofit.scanwere accidentally modified when the POI gets set to constant. Copy the list to prevent changing this external data.resolves #545