fix: Add q0 test statistic as valid option to CLI infer interface #2591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR 👍. Please follow the contribution guide (https://github.com/scikit-hep/pyhf/blob/main/CONTRIBUTING.md) in the future. I'm pretty sure this has been discussed in the past, but we can take a look at why this wasn't previously implemented next week and get back to you. If I'm wrong and this is missing then we can probably add this, given that you have a use case for it. |
The CLI API (e.g. `pyhf cls`) allows the test statistic to be set, but it limits the options to `q` and `qtilde`. However, the discovery test statistic `q0` is also a valid option here, but it can't currently be set on the command line. This commit is a simple fix; it adds `q0` to the list of allowed arguments to `pyhf cls --test-stat`.
matthewfeickert
force-pushed
the
q0_cli_test_stats
branch
from
7be8a23 to
5386131
Compare
|
We discussed this a bit in #1712. While the math is correct, I think it's not ideal to have this live under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CLI API (e.g.
pyhf cls) allows the test statistic to be set, but it limits the options toqandqtilde. However, the discovery test statisticq0is also a valid option here (as described in the documentation), but it can't currently be set on the command line. This commit is a simple fix; it addsq0to the list of allowed arguments topyhf cls --test-stat. With this change one can do something like this to quickly test a workspace on the command line:Since this is a one-line fix, I didn't open an issue first; hopefully that's okay!
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: