Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow dev doc #65

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Disallow dev doc #65

merged 1 commit into from
Aug 27, 2019

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Aug 27, 2019

Xref #61

@soupault
Copy link
Member

I wonder if there is a way to keep both stable and dev versions, but tell the search engines ot prioritize the stable one...

@jni
Copy link
Member

jni commented Aug 27, 2019

Somehow scikit-learn seems to have this worked out... If you search for scikit-learn documentation, the top hits are stable. If you search for scikit-learn dev docs, the top hit is some weird third party site, but the dev docs are in there... =\

@jni
Copy link
Member

jni commented Aug 27, 2019

Having said this, I'm 👍 on this for the moment.

@stefanv stefanv merged commit f5048a4 into master Aug 27, 2019
@stefanv
Copy link
Member

stefanv commented Aug 27, 2019

I kind of hate pushing the merge button here, but everyone seems convinced so in it goes.

@sciunto sciunto deleted the dev-doc branch August 27, 2019 18:57
@sciunto
Copy link
Member Author

sciunto commented Aug 28, 2019

Is there someone who usually takes care of rebuilding the pages?

@soupault
Copy link
Member

soupault commented Aug 28, 2019

@sciunto yes, the authors of the PRs 😉. I have updated the main page recently, the instructions from README.md worked without any issues.

@jni
Copy link
Member

jni commented Aug 28, 2019

@stefanv can you elaborate? I think most people are after stable, not dev, so this makes a lot of sense. We get so many issues from people trying dev examples on stable. I doubt we'll get anywhere near as much this way.

@sciunto
Copy link
Member Author

sciunto commented Aug 28, 2019

@sciunto yes, the authors of the PRs wink. I have updated the main page recently, the instructions from README.md worked without any issues.

Good to know! :D

@sciunto
Copy link
Member Author

sciunto commented Aug 28, 2019

@soupault I guess I do something wrong

I run make gh-pages

  File "_scripts/gh-pages.py", line 109, in <module>
    branch = re.match(b'On branch (.*)$', status).group(1)
AttributeError: 'NoneType' object has no attribute 'group'
make: *** [Makefile:57: gh-pages] Error 1

@soupault
Copy link
Member

🤔 . Are you executing the command from the repo root? What is your Python version?

@sciunto
Copy link
Member Author

sciunto commented Aug 28, 2019

Yes. I'm using Python 3.7.4

@stefanv
Copy link
Member

stefanv commented Aug 28, 2019

@stefanv can you elaborate? I think most people are after stable, not dev, so this makes a lot of sense. We get so many issues from people trying dev examples on stable. I doubt we'll get anywhere near as much this way.

I agree it solves an issue; I think historically my main concern was adoption, so showing off the latest gallery and largest list of functions was important. Perhaps we've graduated into the Big League ;)

@soupault
Copy link
Member

@sciunto at master branch? Maybe try make clean + make gh-pages 🤷‍♂.

@sciunto
Copy link
Member Author

sciunto commented Aug 29, 2019

Oh, I got it. It's due to the language.
If I run first,
LANG=en_EN; LANGUAGE=en_EN:en it passes.

@sciunto
Copy link
Member Author

sciunto commented Aug 29, 2019

updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants