Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cmake version, avoid printing debugging values (do not pull automatically!) #161

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

meilof
Copy link

@meilof meilof commented Aug 19, 2019

Setting version to 3.1 enables using CMAKE_PREFIX_PATH to specify pkg-config locations (see https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L115). This heps for example on Mac OS X if you want to provide a location for libcrypto. With this patch I was able to compile libsnark with

"cmake .. -DCMAKE_PREFIX_PATH=/usr/local/Cellar/openssl/1.0.2s -DWITH_PROCPS=OFF -DWITH_SUPERCOP=OFF"

Setting version to 3.1 enables using CMAKE_PREFIX_PATH to specify pkg-config locations (see https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L115). This heps for example on Mac OS X if you want to provide a location for libcrypto. With this patch I was able to compile libsnark with

"cmake .. -DCMAKE_PREFIX_PATH=/usr/local/Cellar/openssl/1.0.2s -DWITH_PROCPS=OFF -DWITH_SUPERCOP=OFF"
@meilof meilof changed the title Increase cmake version (helps with building on Mac OS X) Increase cmake version (helps with building on Mac OS X), avoid printing debugging values Aug 19, 2019
@meilof
Copy link
Author

meilof commented Aug 19, 2019

Hmm, I see now you should not merge this pull request directly because it will also change the reference to libff (to a version that I also patched to remove debugging output)!

@meilof meilof changed the title Increase cmake version (helps with building on Mac OS X), avoid printing debugging values Increase cmake version, avoid printing debugging values (do not pull automatically!) Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants