Skip to content

Conversation

@andyfaff
Copy link
Contributor

No description provided.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @andyfaff

@rgommers rgommers merged commit b24d8ba into scipy:main Nov 29, 2025
63 of 64 checks passed
@rgommers
Copy link
Member

There is one crash in the cp311-macosx-x86_64-openblas job, but that's clearly unrelated:

  Current thread 0x00007ff854e700c0 (most recent call first):
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/scipy/interpolate/_bsplines.py", line 1948 in _lsq_solve_qr
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/scipy/interpolate/_fitpack_repro.py", line 57 in _get_residuals
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/scipy/interpolate/_fitpack_repro.py", line 969 in _make_splrep_impl
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/scipy/interpolate/_fitpack_repro.py", line 1161 in make_splrep
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/scipy/interpolate/tests/test_bsplines.py", line 3732 in test_make_splrep_with_non_c_contiguous_input
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/python.py", line 166 in pytest_pyfunc_call
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_callers.py", line 121 in _multicall
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_hooks.py", line 512 in __call__
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/python.py", line 1720 in runtest
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/runner.py", line 179 in pytest_runtest_call
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_callers.py", line 121 in _multicall
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_hooks.py", line 512 in __call__
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/runner.py", line 245 in <lambda>
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/runner.py", line 353 in from_call
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/runner.py", line 244 in call_and_report
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/runner.py", line 137 in runtestprotocol
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/runner.py", line 118 in pytest_runtest_protocol
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_callers.py", line 121 in _multicall
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_hooks.py", line 512 in __call__
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/main.py", line 396 in pytest_runtestloop
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_callers.py", line 121 in _multicall
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_hooks.py", line 512 in __call__
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/main.py", line 372 in _main
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/main.py", line 318 in wrap_session
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/main.py", line 365 in pytest_cmdline_main
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_callers.py", line 121 in _multicall
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/pluggy/_hooks.py", line 512 in __call__
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/_pytest/config/__init__.py", line 197 in main
    File "/private/var/folders/3p/0h5j6kv1539gglrgws27xslc0000gn/T/cibw-run-z6raaw1a/cp311-macosx_x86_64/venv-test-x86_64/lib/python3.11/site-packages/scipy/_lib/_testutils.py", line 131 in __call__
    File "<string>", line 1 in <module>
  
  Extension modules: numpy._core._multiarray_umath, numpy.linalg._umath_linalg, _cyutility, scipy._cyutility, scipy._lib._ccallback_c, scipy._lib._fpumode, charset_normalizer.md, numpy.random._common, numpy.random.bit_generator, numpy.random._bounded_integers, numpy.random._pcg64, numpy.random._mt19937, numpy.random._generator, numpy.random._philox, numpy.random._sfc64, numpy.random.mtrand, scipy.sparse._sparsetools, _csparsetools, scipy.sparse._csparsetools, scipy.spatial._ckdtree, scipy._lib.messagestream, scipy.linalg._fblas, scipy.linalg._flapack, scipy.linalg.cython_lapack, scipy.linalg._cythonized_array_utils, scipy.linalg._solve_toeplitz, scipy.linalg._batched_linalg, scipy.linalg._decomp_lu_cython, scipy.linalg._matfuncs_schur_sqrtm, scipy.linalg._matfuncs_expm, scipy.linalg._linalg_pythran, scipy.linalg.cython_blas, scipy.linalg._decomp_update, scipy.spatial._qhull, scipy.spatial._voronoi, scipy.special._ufuncs_cxx, scipy.special._ellip_harm_2, scipy.special._special_ufuncs, scipy.special._gufuncs, scipy.special._ufuncs, scipy.special._specfun, scipy.special._comb, scipy.spatial._hausdorff, scipy.spatial._distance_wrap, scipy.spatial.transform._rotation_cy, scipy.spatial.transform._rigid_transform_cy, scipy.cluster._vq, scipy.cluster._hierarchy, scipy.cluster._optimal_leaf_ordering, scipy.interpolate._fitpack, scipy.interpolate._dfitpack, scipy.sparse.linalg._dsolve._superlu, scipy.sparse.linalg._eigen.arpack._arpacklib, scipy.sparse.linalg._propack, scipy.optimize._group_columns, scipy.optimize._trlib._trlib, scipy.optimize._lbfgsb, _moduleTNC, scipy.optimize._moduleTNC, scipy.optimize._slsqplib, scipy.optimize._minpack, scipy.optimize._lsq.givens_elimination, scipy.optimize._zeros, scipy._lib._uarray._uarray, scipy.linalg._decomp_interpolative, scipy.optimize._bglu_dense, scipy.optimize._lsap, scipy.optimize._direct, scipy.interpolate._dierckx, scipy.interpolate._ppoly, scipy.interpolate._interpnd, scipy.interpolate._rbfinterp_pythran, scipy.interpolate._rgi_cython, scipy.integrate._odepack, scipy.integrate._quadpack, scipy.integrate._vode, scipy.integrate._dop, scipy.special.cython_special, scipy.stats._stats, scipy.stats._biasedurn, scipy.stats._stats_pythran, scipy.stats._levy_stable.levyst, scipy.stats._ansari_swilk_statistics, scipy.sparse.csgraph._tools, scipy.sparse.csgraph._shortest_path, scipy.sparse.csgraph._traversal, scipy.sparse.csgraph._min_spanning_tree, scipy.sparse.csgraph._flow, scipy.sparse.csgraph._matching, scipy.sparse.csgraph._reordering, scipy.stats._sobol, scipy.stats._qmc_cy, scipy.stats._rcont.rcont, scipy.stats._qmvnt_cy, scipy.ndimage._nd_image, scipy.ndimage._rank_filter_1d, _ni_label, scipy.ndimage._ni_label, scipy._lib._test_ccallback, scipy.fftpack.convolve, scipy.io.matlab._mio_utils, scipy.io.matlab._streams, scipy.io.matlab._mio5_utils, scipy.linalg._matfuncs_sqrtm_triu, scipy.ndimage._ctest, _cytest, scipy.ndimage._cytest, scipy.odr.__odrpack, scipy.optimize.cython_optimize._zeros, scipy.signal._sigtools, scipy.signal._max_len_seq_inner, scipy.signal._upfirdn_apply, scipy.signal._spline, scipy.signal._sosfilt, scipy.signal._peak_finding_utils, scipy.special._test_internal, scipy.stats._unuran.unuran_wrapper, scipy._lib._test_deprecation_def, scipy._lib._test_deprecation_call, requests.packages.charset_normalizer.md, requests.packages.chardet.md (total: 121)
  /Users/runner/work/scipy-release/scipy-release/tools/wheels/cibw_test_command.sh: line 25: 60115 Segmentation fault: 11  python -c "import sys; import scipy; sys.exit(not scipy.test())"
  ............................::endgroup::Testing wheel...

That test came in with scipy/scipy#24013 last week, so I will follow up on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants