Skip to content

Conversation

steppi
Copy link
Collaborator

@steppi steppi commented Apr 17, 2025

This PR pins the version of xref in the clone-xsref command to v0.0.0, which I just created it seems like a good idea to pin to a tag to make it easier to keep things in sync. I can imagine a situation where we add a new batch of tests, but don't want to pin to the newest xsref version on main until we have them all passing. Also, this will keep tests for old versions failing if parquet files get removed, renamed, or restructured.

@steppi steppi requested a review from lucascolley April 17, 2025 01:39
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

For slightly more flexibility, we could split it up into separate clone and checkout steps, so one can change the version without having to reclone. But fine to just merge this!

@steppi
Copy link
Collaborator Author

steppi commented Apr 17, 2025

For slightly more flexibility, we could split it up into separate clone and checkout steps, so one can change the version without having to reclone. But fine to just merge this!

That's good thinking, but I want to go in a different direction. I just made the clone shallow to save time:

Clone time on my machine went from

real    0m37.408s
user    0m13.567s
sys     0m7.379s

to

real    0m11.133s
user    0m3.803s
sys     0m2.423s

and things would only get worse as xsref gets more history.

@lucascolley
Copy link
Member

Yep, that's a good argument!

@steppi steppi merged commit 84b4486 into scipy:main Apr 17, 2025
2 of 3 checks passed
@steppi steppi deleted the pin-xsref branch April 26, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants