-
Notifications
You must be signed in to change notification settings - Fork 15
Enforce namespace restrictions #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ctron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. So you'd need to increment the version as well. Otherwise the CI should/will fail.
|
Just a thought: maybe it makes sense to convert the other |
Good thought, also thought that. Didn't realize that there was only one function left, though. 😆 |
|
@ctron Also tried to clean up and streamline dependencies. Maybe you want to review that additional changes before merge? |
b1538e4 to
c7672ad
Compare
|
@ctron One more question: Did you intentionally exclude |
As this is a library, the lock file is not committed as that used to be the default. I wouldn't want to change it just for this project, and as part of this PR. |
Good point, will undo... |
c7672ad to
294c13b
Compare
3774766 to
b2e04b6
Compare
|
@ctron Is the current state acceptable and can we progress to merge? |
|
It would also be very helpful for https://github.com/csaf-rs/csaf to have this released as |
|
@milux hi ctron is on pto I have no gh permission to merge yet 👍 |
|
@milux sorry, I was on vacation and did not update my GH busy status to make this clear. |
|
@ctron Could you please do a |
|
Done! |
Enforces namespace restrictions for all types that prohibit namespaces according to the JSON specs in https://github.com/package-url/purl-spec/tree/main/types at the time being. Selected via the following bash script:
Further fixed the lowercased types. Identified via the following bash script and checked for "must be lowercased" note: