fix: --include parameter for metadata contained in file
#678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 34 +2
Lines 905 948 +43
=========================================
+ Hits 905 948 +43
☔ View full report in Codecov by Sentry. |
mehdicherf
reviewed
Aug 28, 2023
mehdicherf
previously approved these changes
Aug 28, 2023
scolladon
force-pushed
the
fix/include-parameter
branch
from
0501f8b
to
9dc07dc
Compare
scolladon
force-pushed
the
fix/include-parameter
branch
from
9dc07dc
to
9d9b4ca
Compare
|
Code Climate has analyzed commit 9d9b4ca and detected 0 issues on this pull request. View more on Code Climate. |
mehdicherf
approved these changes
Aug 28, 2023
|
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes
Include implementation is now done in post processing.
It deals with inFile metadata more gracefully allowing them to be listed in package.xml and copied (when
-dis set)include destructive also benefit from this improvement
README file has been updated to explain the specificity of this implementation as it requires full repo fetch depth.
micromatchhas been removed from the dependency and ignore implementation has been reused for include (exact inverted logic)E2E tests have been added for include, include-destructive, ignore and ignore-destructive cases
Does this close any currently open issues?
closes #677
Any particular element that can be tested locally
You can use the issue/677 branch in the reproduction playground