Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty inFile metadata file generation when nothing scopable changed #680

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Ensure to write metadata file when it has content even if nothing "scopable" is changed.
And still ensure it will not write empty metadata file when something has been removed from the file and the content is empty

Does this close any currently open issues?


closes #679

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

Any particular element that can be tested locally


Any other comments


@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (561fd48) 100.00% compared to head (e65d5ed) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #680   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines          948       952    +4     
=========================================
+ Hits           948       952    +4     
Files Changed Coverage Δ
src/service/ObjectTranslationHandler.js 100.00% <100.00%> (ø)
src/service/inFileHandler.js 100.00% <100.00%> (ø)
src/utils/fxpHelper.js 100.00% <100.00%> (ø)
src/utils/metadataDiff.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeclimate
Copy link

codeclimate bot commented Aug 29, 2023

Code Climate has analyzed commit e65d5ed and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 0b3413c into main Aug 30, 2023
21 checks passed
@scolladon scolladon deleted the fix/inFile-untracked-metadata-changed-generate-empty branch August 30, 2023 08:41
@github-actions
Copy link

Shipped in release v5.25.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SGD command not generating delta on profile files
2 participants