-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle decomposed type #825
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 39 +2
Lines 1044 1068 +24
Branches 113 115 +2
=========================================
+ Hits 1044 1068 +24 ☔ View full report in Codecov by Sentry. |
3f38348
to
956bc52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @scolladon !
It's a fairly big refactoring, so once merged I would suggest to leave it as a release candidate for a while to test it extensively 😄
I agree @mehdisfdc, but before we should put the current latest to the same version as the current latest-rc. What I propose :
Apart from that, doing this refactoring made me realized we have a built a big mechanism and logic around metadata, which seems to be built (not really long ago) inside SDR... I really consider refactoring our implementation using this library instead of our in house metadata engine in order to simplify a lot our implementation. |
50e8cd6
to
d158590
Compare
1938cd9
to
1eb4f3d
Compare
Published under $ sfdx plugins:install sfdx-git-delta@beta-825 |
1eb4f3d
to
7cd86c0
Compare
Code Climate has analyzed commit 4d4487f and detected 0 issues on this pull request. View more on Code Climate. |
Published under $ sfdx plugins:install sfdx-git-delta@dev-825 |
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected] Happy incremental deployment! |
This reverts commit ec9ea59.
Explain your changes
Goal of this pull request is to handle the new decomposed type discussed here and released here
We have to make the distinction between those kind of types :
Decomposed file that represent a metadata in itself (and could be deployed standalone like workflow rule)
Decomposed file that represent a part of a metadata (and does not represent a metadata kind like field permission) (exemple: Profile)
Decomposed file same as the previous one but it cannot be deployed partially and requires everything else to deployed as well (exemple: PermissionSet)
Jest tests added to cover the fix.
NUT tests added to cover the fix.
E2E tests added to cover the fix.