Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow resource type detection by extension #882

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Allow to detect resource type via file extension

Does this close any currently open issues?


closes #876

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

@scolladon scolladon force-pushed the fix/inResource-extension-detection branch from b600ec4 to fceff7e Compare June 13, 2024 10:49
@scolladon scolladon force-pushed the fix/inResource-extension-detection branch from fceff7e to e9f9f51 Compare June 13, 2024 10:53
Copy link

codeclimate bot commented Jun 13, 2024

Code Climate has analyzed commit e9f9f51 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (79ffddf) to head (e9f9f51).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #882   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1067      1066    -1     
  Branches       114       115    +1     
=========================================
- Hits          1067      1066    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon merged commit 61524c6 into main Jun 13, 2024
18 of 22 checks passed
@scolladon scolladon deleted the fix/inResource-extension-detection branch June 13, 2024 11:30
Copy link

Shipped in release v5.40.2.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission set difference generated with incorrect 'force-app' text
1 participant