Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use keywords instead of keyword in package.json #885

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

amtrack
Copy link
Contributor

@amtrack amtrack commented Jun 14, 2024

Thanks for this awesome plugin. I'm using it in several projects!

I'm working on a website for exploring awesome sfdx/sf plugins and was wondering why it didn't show sfdx-git-delta.

https://amtrack.github.io/sf-plugin-explorer/

Untitled

https://docs.npmjs.com/cli/v10/configuring-npm/package-json#keywords

@amtrack amtrack requested a review from scolladon as a code owner June 14, 2024 08:03
Copy link

codeclimate bot commented Jun 14, 2024

Code Climate has analyzed commit a63474a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Thanks for this contribution in the plugin visibility

@scolladon scolladon changed the title fix: use keywords instead of keyword in package.json build: use keywords instead of keyword in package.json Jun 14, 2024
@scolladon
Copy link
Owner

I changed the title to "build" instead of "fix" to avoid creating a release candidat PR and avoid having this listed in the release note as it is not a feature nor a fix for the plugin itself

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (14adfac) to head (a63474a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #885   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1066      1066           
  Branches       115       115           
=========================================
  Hits          1066      1066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon merged commit 1eab3b8 into scolladon:main Jun 14, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants