Add alternative key method #845
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmehant
requested changes
Dec 25, 2019
|
Please squash your commits :) |
Fix Codacy errors Use os.environ.get Change reference to string
…ai/Bassa into hard-code-alternative
JaDogg
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed config file to get the server secret key from an environment variable.
Description
Used the
osmodule in the Bassa core config Python file to grab theBASSA_SERVER_KEYenvironment variable.Motivation and Context
This solves a major problem with security as most configurations and instances of Bassa might not change this default SERVER_SECRET_KEY as the project will work without this configuration since it is hard coded.
How Has This Been Tested?
Ran the project.
Types of changes
Checklist: