added changes to flask-server to configure admin panel #498
Conversation
|
@Anmolbansal1 the build is failing because the generate_password_hash method takes a not null value and i have imported an env variable for admin_password and thus stays null during the build. Please guide me as to what i should do now? |
|
@Anmolbansal1 the build is failing because the generate_password_hash method takes a not null value and i have imported an env variable for admin_password and thus stays null during the build. |
pulling changes
|
@Anmolbansal1 what are your views on this? |
masters merged
|
@Anmolbansal1 thinking of making a script for creating admins. What say? |
carpecodeum
force-pushed
the
admin-server-added
branch
3 times, most recently
from
67a3dd7 to
727daca
Compare
carpecodeum
requested review from
Anmolbansal1
and removed request for
Anmolbansal1
| @@ -43,7 +43,7 @@ SQLAlchemy==1.2.18 | |||
| tornado==6.0 | |||
| tweepy==3.8.0 | |||
| typed-ast==1.2.0 | |||
| urllib3==1.24.1 | |||
| urllib3==1.23.0 | |||
There was a problem hiding this comment.
Why is this package version changed??
There was a problem hiding this comment.
this was changed as a result of a warning coming during the setup.
| @@ -0,0 +1,66 @@ | |||
| """empty message | |||
There was a problem hiding this comment.
I think that two migrations files are unnecessary as only a new column is added to user table, so try to generate only corresponding to that change
fact-bounty-flask/api/commands.py
Outdated
| except Exception as e: | ||
| print(str(e)) | ||
| response = {"message": "Something went wrong!!"} | ||
| return make_response(jsonify(response)), 500 |
There was a problem hiding this comment.
It's unclear why this method return a response like a route, it's just a click command. Also please attach some screenshot demonstrating this change.
|
|
||
|
|
There was a problem hiding this comment.
Please remove these unnecessary black lines
| user_id = get_jwt_identity() | ||
| user = model.User.find_by_user_id(user_id) | ||
|
|
||
| es_index = current_app.config["ES_INDEX"] | ||
| es = current_app.elasticsearch | ||
| if user.role == "admin": | ||
| es_index = current_app.config["ES_INDEX"] | ||
| es = current_app.elasticsearch |
There was a problem hiding this comment.
This file changes looks good, could you attach screenshots on request this url with admin user, you may use postman 😄
fact-bounty-flask/api/app.py
Outdated
| return app | ||
| except Exception as err: | ||
| print("Error occured:", err) | ||
| return app |
There was a problem hiding this comment.
Why have you removed this error handling of flask app??
carpecodeum
force-pushed
the
admin-server-added
branch
from
727daca to
45dc00f
Compare
carpecodeum
force-pushed
the
admin-server-added
branch
2 times, most recently
from
f88d871 to
2c3b8a0
Compare
…authenticated the stories/all route using jwt
Decorator fix Codacy fix
carpecodeum
force-pushed
the
admin-server-added
branch
from
2c3b8a0 to
7d9d4c8
Compare
Please provide enough information so that others can review your pull request:
added changes to flask-server to configure the admin panel on the client side
Explain the details for making this change. What existing problem does the pull request solve?
changes in the helpers.py and stories.controller.py allow the endpoint api/stories/all to be served only when the user is admin
also updated the read me to allow .env file to incorporate the credentials for admin.
Test plan (required)
tested using postman that the data of all the stories is served only when the user is an admin
Closing issues #470