Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin controller and a command to make admins #527

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

carpecodeum
Copy link
Contributor

@carpecodeum carpecodeum commented Mar 9, 2020

Please provide enough information so that others can review your pull request:
Add admin controller and a command to make admins and allow only admins to access the stories/all route

Explain the details for making this change. What existing problem does the pull request solve?

This solves the issue of making admins for viewing and protecting certain routes like stories/all

Test plan (required)

Screenshot 2020-03-09 at 7 24 16 PM

Screenshot 2020-03-08 at 2 45 22 PM

Closing issues #470

Put closes #XXXX in your comment and commit message to auto-close the issue that your PR fixes (if such).

Copy link
Collaborator

@Anmolbansal1 Anmolbansal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix minor codacy errors and make a function in user class to check wether user is admin, else great work 👍

@carpecodeum
Copy link
Contributor Author

Sure @Anmolbansal1! Thanks for reviewing!

Copy link
Collaborator

@Anmolbansal1 Anmolbansal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing

@Anmolbansal1
Copy link
Collaborator

Any update @carpecodeum , this pr is actually important for further changes so try to fix this like ASAP

@Anmolbansal1
Copy link
Collaborator

Just squash all commits and fix these minor codacy errors to maintain code standards 😃

@carpecodeum
Copy link
Contributor Author

Any update @carpecodeum , this pr is actually important for further changes so try to fix this like ASAP

Yes! I will fix them asap. Sorry for the delay.

@carpecodeum
Copy link
Contributor Author

@Anmolbansal1 I think there is a problem with codacy. Its detecting errors even in the basic multi line commenting also in the way we initialise params in classmethod functions.This was happening before also, Please can you look into it and tell me if there is any problem from my side.

@carpecodeum
Copy link
Contributor Author

@Anmolbansal1 I tried fixing this again its giving a warning. can you please look?

Copy link
Collaborator

@Anmolbansal1 Anmolbansal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Anmolbansal1 Anmolbansal1 merged commit 6e5ae42 into scorelab:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants