-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin controller and a command to make admins #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix minor codacy errors and make a function in user class to check wether user is admin, else great work 👍
Sure @Anmolbansal1! Thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still failing
Any update @carpecodeum , this pr is actually important for further changes so try to fix this like ASAP |
Just squash all commits and fix these minor codacy errors to maintain code standards 😃 |
Yes! I will fix them asap. Sorry for the delay. |
7596e94
to
4dd2ea2
Compare
@Anmolbansal1 I think there is a problem with codacy. Its detecting errors even in the basic multi line commenting also in the way we initialise params in classmethod functions.This was happening before also, Please can you look into it and tell me if there is any problem from my side. |
…ns to acces the stories/all route
4dd2ea2
to
7360ce9
Compare
@Anmolbansal1 I tried fixing this again its giving a warning. can you please look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Please provide enough information so that others can review your pull request:
Add admin controller and a command to make admins and allow only admins to access the stories/all route
Explain the details for making this change. What existing problem does the pull request solve?
This solves the issue of making admins for viewing and protecting certain routes like stories/all
Test plan (required)
Closing issues #470
Put
closes #XXXX
in your comment and commit message to auto-close the issue that your PR fixes (if such).