Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-8406: Have Pluto Github workflow grab dependencies from jfrog #26

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

cttttt
Copy link
Contributor

@cttttt cttttt commented Feb 12, 2025

Re: https://thescore.atlassian.net/browse/SRE-8406

During Pluto checks, fetches helm chart dependencies prior to rendering helm template. This is now required since some helm charts depend on a core SRERE helm chart, stored in our private jfrog repo. Although jfrog is accessible from the internet, its credentials live in Vault, which is not reachable from the internet.

Changes:

  • Uses SRERE's handy action to authenticate with jfrog.
  • This action requires Vault access. Since vault is inaccessible from the internet, uses our internal Github runners.
  • Unfortunately replaces an upstream action to install Pluto. This action depends on podman, which is not available from our Github Actions self-hosted runners (we use Docker as our container runtime).
  • Fetches helm dependencies prior to trying to render a template.

How do I know this works?

See the before and after in this workflow run: link.

This run was invoked from this branch of scorebet/edgebook-manifests. In this branch, I modified just the edgebook pluto check workflow invocation to use this pull request branch's version of the workflow.

Notes for reviewers:

Github workflows are myserious and interesting. Review commit by commit to track my journey.

@cttttt cttttt requested a review from a team as a code owner February 12, 2025 22:57
@cttttt cttttt merged commit 676e569 into master Feb 13, 2025
7 checks passed
@cttttt cttttt deleted the allow-fetch-from-jfrog-take-2 branch February 13, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants