SRE-8406: Have Pluto Github workflow grab dependencies from jfrog #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://thescore.atlassian.net/browse/SRE-8406
During Pluto checks, fetches helm chart dependencies prior to rendering helm template. This is now required since some helm charts depend on a core SRERE helm chart, stored in our private jfrog repo. Although jfrog is accessible from the internet, its credentials live in Vault, which is not reachable from the internet.
Changes:
podman
, which is not available from our Github Actions self-hosted runners (we use Docker as our container runtime).How do I know this works?
See the before and after in this workflow run: link.
This run was invoked from this branch of
scorebet/edgebook-manifests
. In this branch, I modified just theedgebook
pluto check workflow invocation to use this pull request branch's version of the workflow.Notes for reviewers:
Github workflows are myserious and interesting. Review commit by commit to track my journey.