feat: add scheduled job to purge expired idempotency keys and impleme… - #555
Open
Johnsource-hub wants to merge 1 commit into
Open
Conversation
…nt related database functionality
Contributor
|
resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes
#481
Summary
Adds a periodic cleanup job that deletes expired idempotency-key rows from the database to prevent unbounded growth.
Wires the purge job into application startup and exposes a manual script to run the purge from CLI/cron.
Adds tests that assert expired rows are removed while active rows are preserved.
Why
idempotency_keys rows were never removed; this leads to unbounded table growth. The purge preserves in-window keys and deletes expired ones.
Implementation notes
Purge logic:
Function purgeExpiredIdempotencyKeys(now?: number): number deletes rows with expires_at <= now and returns the number of deleted rows.
A scheduler startIdempotencyPurgeJob(intervalMs?: number) uses setInterval to run the purge at a configurable cadence.
getIdempotencyRecord and recordIdempotencyKey follow the same expiry semantics used by the middleware so behavior for in-window keys is unchanged.
and test OK in isolation.
Acceptance checklist
Expired idempotency key rows are deleted by the purge
Unexpired rows are not deleted
Purge runs on a configurable periodic schedule at startup
Manual npm run purge:idempotency-keys runner added
Regression test asserts behavior