qtFRED variables editor #6150
Open
qtFRED variables editor #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not building yet. Some sort of linking error
Also, add a few declarations for List and Map contents editing.
And add stubs for other model functions we'll need
and a few other functions
And container functions
Add it to the editor menu (with shortcut), and fix it showing up when started
Edits were previously done on a machine that could not build or use a linter.
And correct the Apply function some.
And clean up dialog model slightly
And other things
Instead of name.
This helps prevent name collisions
JohnAFernandez
added
qtfred
JohnAFernandez
force-pushed
the
qtFRED-variables-editor
branch
from
6458258 to
1945a09
Compare
JohnAFernandez
force-pushed
the
qtFRED-variables-editor
branch
from
1945a09 to
87367d6
Compare
|
While I still have to do a last run of tests on the last two features I added, this is now basically done and ready for review. |
Implements container contents reading, as well
Goober5000
added
the
Waiting for Stable
Goober5000
removed
the
Waiting for Stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because there are a couple more issues to iron out with character limits of list and map items and applying the changes to the mission, but it's close enough to being done that people can start taking a look. The basic functionality is pretty well tested, but I think we'll need some real-world testing once it's in.
Note: This allows duplicate keys until the dialog is accepted, at which point it checks for duplicate keys, warns the user and prevents saving, listing the exact items that are problematic. This allows users to make edits without qtFRED erasing user inputs if they happen to be duplicates. But that means that keys are not really keys until saved to the mission.
There's some new features as well, like value-key switching. Variable and container copying, etc.