Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow per-stage briefing grid colors #6448

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MjnMixael
Copy link
Contributor

Allows setting a custom grid color for each briefing stage with
$grid_color: (r, g, b, a)

For now there's no UI because this is decidedly niche and would be much easier to do in qt with a full color picker.

@wookieejedi wookieejedi added enhancement A new feature or upgrade of an existing feature to add additional functionality. ui A feature or issue specific to the menus portion of the user interface labels Dec 2, 2024
@MjnMixael MjnMixael added this to the Release 25.0 milestone Dec 6, 2024
Copy link
Member

@BMagnu BMagnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small function signature changes.

code/graphics/2d.cpp Outdated Show resolved Hide resolved
code/mission/missionbriefcommon.cpp Outdated Show resolved Hide resolved
code/mission/missionbriefcommon.cpp Outdated Show resolved Hide resolved
Copy link
Member

@BMagnu BMagnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good.
One thing to note which I forgot to tag in the first review is that this also needs to correctly perform checks for version-specific data on-save to correctly set the minimum required FSO-version in the PR. See line 3159 of FRED's missionsave.cpp

@MjnMixael
Copy link
Contributor Author

Changes seem good. One thing to note which I forgot to tag in the first review is that this also needs to correctly perform checks for version-specific data on-save to correctly set the minimum required FSO-version in the PR. See line 3159 of FRED's missionsave.cpp

Done

Copy link
Member

@BMagnu BMagnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically good to go, but two tiny potential issues we should remedy

fred2/missionsave.cpp Outdated Show resolved Hide resolved
qtfred/src/mission/missionsave.cpp Outdated Show resolved Hide resolved
fred2/missionsave.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or upgrade of an existing feature to add additional functionality. ui A feature or issue specific to the menus portion of the user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants