-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow per-stage briefing grid colors #6448
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small function signature changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem good.
One thing to note which I forgot to tag in the first review is that this also needs to correctly perform checks for version-specific data on-save to correctly set the minimum required FSO-version in the PR. See line 3159 of FRED's missionsave.cpp
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically good to go, but two tiny potential issues we should remedy
Allows setting a custom grid color for each briefing stage with
$grid_color: (r, g, b, a)
For now there's no UI because this is decidedly niche and would be much easier to do in qt with a full color picker.