Update JOY_NUM_BUTTONS to 128 #6479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to scp-fs2open#6371 (and replaces scp-fs2open#5960 since the goal of that PR was already taken care of with scp-fs2open#6371 adding the procedural translation). Overall tagging this as 25.0 since multiple folks have asking about bumping the limit
wookieejedi
added
enhancement
|
Tests with high number of input buttons work as do devices with lower numbers and none. This is ready for review. |
Goober5000
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6371 (and replaces #5960 since the goal of that PR was already taken care of with #6371 adding the procedural translation).
Overall tagging this as 25.0 since multiple folks have asking about bumping the limit. In draft status pending more testing.