Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add safeguards to the "immobile" flag migration #6492

Merged

Conversation

Goober5000
Copy link
Contributor

When a mission is loaded in FRED the "immobile" flag is migrated to "don't-change-position" and "don't-change-orientation". So, notify the FREDder that this is happening, and add checks to the "potential issues" checker to guard against mixing the old and new flags.

Follow-up to #6304. Resolves #6489.

When a mission is loaded in FRED the "immobile" flag is migrated to "don't-change-position" and "don't-change-orientation".  So, notify the FREDder that this is happening, and add checks to the "potential issues" checker to guard against mixing the old and new flags.

Follow-up to scp-fs2open#6304.  Resolves scp-fs2open#6489.
@Goober5000 Goober5000 added enhancement A new feature or upgrade of an existing feature to add additional functionality. sexps A feature or issue related to SEXPs fred A feature or issue related to the FReespace EDitor (FRED) labels Dec 28, 2024
Copy link
Member

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and looks good to me

@Goober5000 Goober5000 merged commit c3e9099 into scp-fs2open:master Dec 29, 2024
16 checks passed
@Goober5000 Goober5000 deleted the immobile_flag_migration_checks branch December 29, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or upgrade of an existing feature to add additional functionality. fred A feature or issue related to the FReespace EDitor (FRED) sexps A feature or issue related to SEXPs
Projects
None yet
2 participants