-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mission goals hook #6534
Mission goals hook #6534
Conversation
8fb5c64
to
80f0114
Compare
80f0114
to
2b4f49b
Compare
Code looks good! Only thing I'd suggest is tuning the hook name to "On Mission Goal Status Changed". Two reasons is that in most places they are referred to as goals, and "On Mission Objectives Changed" might imply adding or removing objectives, or validation/invalidation of objectives, which are the case with this hook :) |
Good thought. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adds an overridable On Mission Objectives Changed hook that runs when an objective is failed or completed. Overriding the hook only overrides display and music methods. The objective state still gets added to the mission log and all background logic continues.