Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make line-of-sight objects aware of its subclasses #6535

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

Goober5000
Copy link
Contributor

@Goober5000 Goober5000 commented Jan 17, 2025

Looking through all places in the scripting API where l_Object.Set() is called, here is one where we might want to know about the object's breed.

(Normally we would return the result of ade_set_object_with_breed(), but the testLineOfSight_internal() function has multiple return arguments.)

@Goober5000 Goober5000 added fix A fix for bugs, not-a-bugs, and/or regressions. scripting A feature or issue related to LUA scripting labels Jan 17, 2025
Looking through all places in the scripting API where `l_Object.Set()` is called, here is one where we might want to know about the object's breed.

(Normally we would return the result of `ade_set_object_with_breed()`, but the `testLineOfSight_internal()` function has multiple return arguments.)
@Goober5000 Goober5000 changed the title make object aware of its subclasses make line-of-sight objects aware of its subclasses Jan 18, 2025
@Goober5000 Goober5000 merged commit b1406bc into scp-fs2open:master Jan 18, 2025
16 checks passed
@Goober5000 Goober5000 deleted the set_with_breed branch January 18, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for bugs, not-a-bugs, and/or regressions. scripting A feature or issue related to LUA scripting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants