Build in the common z load first methods and forwarders #6545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookieejedi
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most mods that have used scripting in the last decade have included the same z_load_first-sct.tbm file. I honestly forgot about that file, but even BtA uses it. So I took and look and thought we should really just build all this in to increase the QoL of our scripters.
The basic forwarders like
print()->ba.print()just make too much sense not to have. I could take or leave the Globals table but it's nice to have.I then also added Nuke's
include()method. I'm not sure that's really necessary since we have m!m's built-inrequire()forwarder that forwards Lua's require to our cfile system already. But it can't really hurt to have it and it's likely some mods have used it.