Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versioned CLDR data. #830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kishan3
Copy link

@kishan3 kishan3 commented Nov 5, 2020

As per the instructions on #826. I have tried for version 32.0.0

As per the instructions on scrapinghub#826. I have tried for version 32.0.0
@kishan3 kishan3 requested a review from noviluni November 5, 2020 09:50
@kishan3
Copy link
Author

kishan3 commented Nov 24, 2020

Hello @noviluni! Can you please provide your feedback on this when you get time? Thanks!

@noviluni
Copy link
Collaborator

Hi, yes @kishan3, I was waiting to merge this: #601 before as it will be necessary to update the docs and it was merged 13 hours ago :)

I think it will be also a good idea to wait for this to be merged: #805 to avoid conflicts.

I mentioned I would handle the first update as it's something that has been never done and I need to polish the process: #826 (comment), but I can try to do the same by providing feedback here. Let me handle first the #805 issue and then I will come again here.

@kishan3
Copy link
Author

kishan3 commented Nov 25, 2020

Ok thanks @noviluni !

@kishan3
Copy link
Author

kishan3 commented Feb 3, 2021

Hello @noviluni 👋 How are you.
Are we proceeding with these changes?

@noviluni
Copy link
Collaborator

noviluni commented Feb 3, 2021

Hi @kishan3!

We will continue working on this after merging this: #805 to avoid conflicts.

However, we can't merge that because the travis-ci pipelines stopped working and we need to enable Github actions: #859 before merging any new PR.

I will try to focus on finishing that PR (help is welcomed), but I need some time. I will notify you as soon as I merge it :)

@kishan3
Copy link
Author

kishan3 commented Feb 3, 2021

Thanks @noviluni Let me see if I can help with any of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants