Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of AutoExtractErrors #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Better handling of AutoExtractErrors #34

wants to merge 3 commits into from

Conversation

BurnzZ
Copy link
Member

@BurnzZ BurnzZ commented Feb 4, 2022

Fixes #33

@BurnzZ BurnzZ added the enhancement New feature or request label Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022 •
edited
Loading

Codecov Report

Merging #34 (ba78b2c) into master (e8b7770) will increase coverage by 0.11%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   85.24%   85.36%   +0.11%     
==========================================
  Files           9        9              
  Lines         488      492       +4     
==========================================
+ Hits          416      420       +4     
  Misses         72       72
Impacted Files Coverage Δ
scrapy_autoextract/middlewares.py 79.19% <72.72%> (+0.49%) ⬆️

@BurnzZ BurnzZ mentioned this pull request Feb 4, 2022
Open
@BurnzZ
update CHANGES.rst to reflect new AUTOEXTRACT_RESPONSE_ERROR_LOG_LEVE…
ba78b2c 
…L and AUTOEXTRACT_ALLOWED_RESPONSE_ERRORS settings
@BurnzZ BurnzZ requested a review from kmike March 30, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmike kmike Awaiting requested review from kmike

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ability to handle AutoExtractError
1 participant
@BurnzZ