Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov action #453

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Update codecov action #453

merged 1 commit into from
Jul 15, 2024

Conversation

VMRuiz
Copy link
Collaborator

@VMRuiz VMRuiz commented Jul 15, 2024

For some reason, codecov was not working with the previous version.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@643a841). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #453   +/-   ##
=========================================
  Coverage          ?   79.51%           
=========================================
  Files             ?       76           
  Lines             ?     3237           
  Branches          ?      537           
=========================================
  Hits              ?     2574           
  Misses            ?      593           
  Partials          ?       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VMRuiz VMRuiz requested a review from Gallaecio July 15, 2024 13:59
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the change, but both approaches seem allowed based on the upstream README.

@VMRuiz VMRuiz merged commit 6fe8928 into master Jul 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants